Bug Summary

File:snes/interface/snesj.c
Warning:line 81, column 10
3rd function call argument is an uninitialized value

Annotated Source Code

[?] Use j/k keys for keyboard navigation

1
2#include <petsc/private/snesimpl.h> /*I "petscsnes.h" I*/
3#include <petscdm.h>
4
5/*@C
6 SNESComputeJacobianDefault - Computes the Jacobian using finite differences.
7
8 Collective on SNES
9
10 Input Parameters:
11+ x1 - compute Jacobian at this point
12- ctx - application's function context, as set with SNESSetFunction()
13
14 Output Parameters:
15+ J - Jacobian matrix (not altered in this routine)
16- B - newly computed Jacobian matrix to use with preconditioner (generally the same as J)
17
18 Options Database Key:
19+ -snes_fd - Activates SNESComputeJacobianDefault()
20. -snes_test_err - Square root of function error tolerance, default square root of machine
21 epsilon (1.e-8 in double, 3.e-4 in single)
22- -mat_fd_type - Either wp or ds (see MATMFFD_WP or MATMFFD_DS)
23
24 Notes:
25 This routine is slow and expensive, and is not currently optimized
26 to take advantage of sparsity in the problem. Although
27 SNESComputeJacobianDefault() is not recommended for general use
28 in large-scale applications, It can be useful in checking the
29 correctness of a user-provided Jacobian.
30
31 An alternative routine that uses coloring to exploit matrix sparsity is
32 SNESComputeJacobianDefaultColor().
33
34 Level: intermediate
35
36.keywords: SNES, finite differences, Jacobian
37
38.seealso: SNESSetJacobian(), SNESComputeJacobianDefaultColor(), MatCreateSNESMF()
39@*/
40PetscErrorCode SNESComputeJacobianDefault(SNES snes,Vec x1,Mat J,Mat B,void *ctx)
41{
42 Vec j1a,j2a,x2;
1
'j1a' declared without an initial value
43 PetscErrorCode ierr;
44 PetscInt i,N,start,end,j,value,root;
45 PetscScalar dx,*y,wscale;
46 const PetscScalar *xx;
47 PetscReal amax,epsilon = PETSC_SQRT_MACHINE_EPSILON1.490116119384766e-08;
48 PetscReal dx_min = 1.e-16,dx_par = 1.e-1,unorm;
49 MPI_Comm comm;
50 PetscBool assembled,use_wp = PETSC_TRUE,flg;
51 const char *list[2] = {"ds","wp"};
52 PetscMPIInt size;
53 const PetscInt *ranges;
54
55 PetscFunctionBegindo { do { ; if (petscstack && (petscstack->currentsize
< 64)) { petscstack->function[petscstack->currentsize
] = __func__; petscstack->file[petscstack->currentsize]
= "/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
; petscstack->line[petscstack->currentsize] = 55; petscstack
->petscroutine[petscstack->currentsize] = PETSC_TRUE; petscstack
->currentsize++; } if (petscstack) { petscstack->hotdepth
+= (PETSC_FALSE || petscstack->hotdepth); } ; } while (0)
; ; } while (0)
;
56 /* Since this Jacobian will possibly have "extra" nonzero locations just turn off errors for these locations */
57 ierr = MatSetOption(B,MAT_NEW_NONZERO_ALLOCATION_ERR, PETSC_FALSE);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),57,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
58 ierr = PetscOptionsGetReal(((PetscObject)snes)->options,((PetscObject)snes)->prefix,"-snes_test_err",&epsilon,0);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),58,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
59
60 ierr = PetscObjectGetComm((PetscObject)x1,&comm);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),60,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
61 ierr = MPI_Comm_size(comm,&size);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),61,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
62 ierr = MatAssembled(B,&assembled);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),62,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
63 if (assembled) {
2
Assuming 'assembled' is 0
3
Taking false branch
64 ierr = MatZeroEntries(B);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),64,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
65 }
66 if (!snes->nvwork) {
4
Assuming the condition is false
5
Taking false branch
67 if (snes->dm) {
68 ierr = DMGetGlobalVector(snes->dm,&j1a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),68,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
69 ierr = DMGetGlobalVector(snes->dm,&j2a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),69,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
70 ierr = DMGetGlobalVector(snes->dm,&x2);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),70,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
71 } else {
72 snes->nvwork = 3;
73 ierr = VecDuplicateVecs(x1,snes->nvwork,&snes->vwork);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),73,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
74 ierr = PetscLogObjectParents(snes,snes->nvwork,snes->vwork)0;{int _i; for (_i=0; _i<(snes->nvwork); _i++) {ierr = PetscLogObjectParent
((PetscObject)(snes),(PetscObject)(snes->vwork)[_i]);do {if
(__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm)
0x44000001),74,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0);}}
;CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),74,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
75 j1a = snes->vwork[0]; j2a = snes->vwork[1]; x2 = snes->vwork[2];
76 }
77 }
78
79 ierr = VecGetSize(x1,&N);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),79,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
80 ierr = VecGetOwnershipRange(x1,&start,&end);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),80,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
81 ierr = SNESComputeFunction(snes,x1,j1a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),81,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
6
3rd function call argument is an uninitialized value
82
83 ierr = PetscOptionsBegin(PetscObjectComm((PetscObject)snes),((PetscObject)snes)->prefix,"Differencing options","SNES")0; do { PetscOptionItems PetscOptionsObjectBase; PetscOptionItems
*PetscOptionsObject = &PetscOptionsObjectBase; PetscMemzero
(PetscOptionsObject,sizeof(PetscOptionItems)); for (PetscOptionsObject
->count=(PetscOptionsPublish?-1:1); PetscOptionsObject->
count<2; PetscOptionsObject->count++) { PetscErrorCode _5_ierr
= PetscOptionsBegin_Private(PetscOptionsObject,PetscObjectComm
((PetscObject)snes),((PetscObject)snes)->prefix,"Differencing options"
,"SNES");do {if (__builtin_expect(!!(_5_ierr),0)) return PetscError
(((MPI_Comm)0x44000001),83,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,_5_ierr,PETSC_ERROR_REPEAT," ");} while (0);
;CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),83,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
84 ierr = PetscOptionsEList("-mat_fd_type","Algorithm to compute difference parameter","SNESComputeJacobianDefault",list,2,"wp",&value,&flg)PetscOptionsEList_Private(PetscOptionsObject,"-mat_fd_type","Algorithm to compute difference parameter"
,"SNESComputeJacobianDefault",list,2,"wp",&value,&flg
)
;CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),84,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
85 ierr = PetscOptionsEnd()_5_ierr = PetscOptionsEnd_Private(PetscOptionsObject);do {if (
__builtin_expect(!!(_5_ierr),0)) return PetscError(((MPI_Comm
)0x44000001),85,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,_5_ierr,PETSC_ERROR_REPEAT," ");} while (0);}} while (0)
;CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),85,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
86 if (flg && !value) use_wp = PETSC_FALSE;
87
88 if (use_wp) {
89 ierr = VecNorm(x1,NORM_2,&unorm);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),89,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
90 }
91 /* Compute Jacobian approximation, 1 column at a time.
92 x1 = current iterate, j1a = F(x1)
93 x2 = perturbed iterate, j2a = F(x2)
94 */
95 for (i=0; i<N; i++) {
96 ierr = VecCopy(x1,x2);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),96,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
97 if (i>= start && i<end) {
98 ierr = VecGetArrayRead(x1,&xx);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),98,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
99 if (use_wp) dx = PetscSqrtReal(1.0 + unorm)sqrt(1.0 + unorm);
100 else dx = xx[i-start];
101 ierr = VecRestoreArrayRead(x1,&xx);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),101,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
102 if (PetscAbsScalar(dx) < dx_min) dx = (PetscRealPart(dx)(dx) < 0. ? -1. : 1.) * dx_par;
103 dx *= epsilon;
104 wscale = 1.0/dx;
105 ierr = VecSetValues(x2,1,&i,&dx,ADD_VALUES);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),105,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
106 } else {
107 wscale = 0.0;
108 }
109 ierr = VecAssemblyBegin(x2);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),109,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
110 ierr = VecAssemblyEnd(x2);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),110,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
111 ierr = SNESComputeFunction(snes,x2,j2a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),111,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
112 ierr = VecAXPY(j2a,-1.0,j1a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),112,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
113 /* Communicate scale=1/dx_i to all processors */
114 ierr = VecGetOwnershipRanges(x1,&ranges);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),114,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
115 root = size;
116 for (j=size-1; j>-1; j--) {
117 root--;
118 if (i>=ranges[j]) break;
119 }
120 ierr = MPI_Bcast(&wscale,1,MPIU_SCALAR,root,comm)((petsc_allreduce_ct += PetscMPIParallelComm((comm)),0) || MPI_Bcast
((&wscale),(1),(((MPI_Datatype)0x4c00080b)),(root),(comm)
))
;CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),120,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
121
122 ierr = VecScale(j2a,wscale);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),122,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
123 ierr = VecNorm(j2a,NORM_INFINITY,&amax);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),123,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
; amax *= 1.e-14;
124 ierr = VecGetArray(j2a,&y);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),124,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
125 for (j=start; j<end; j++) {
126 if (PetscAbsScalar(y[j-start]) > amax || j == i) {
127 ierr = MatSetValues(B,1,&j,1,&i,y+j-start,INSERT_VALUES);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),127,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
128 }
129 }
130 ierr = VecRestoreArray(j2a,&y);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),130,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
131 }
132 if (snes->dm) {
133 ierr = DMRestoreGlobalVector(snes->dm,&j1a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),133,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
134 ierr = DMRestoreGlobalVector(snes->dm,&j2a);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),134,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
135 ierr = DMRestoreGlobalVector(snes->dm,&x2);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),135,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
136 }
137 ierr = MatAssemblyBegin(B,MAT_FINAL_ASSEMBLY);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),137,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
138 ierr = MatAssemblyEnd(B,MAT_FINAL_ASSEMBLY);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),138,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
139 if (B != J) {
140 ierr = MatAssemblyBegin(J,MAT_FINAL_ASSEMBLY);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),140,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
141 ierr = MatAssemblyEnd(J,MAT_FINAL_ASSEMBLY);CHKERRQ(ierr)do {if (__builtin_expect(!!(ierr),0)) return PetscError(((MPI_Comm
)0x44000001),141,__func__,"/sandbox/petsc/petsc.next-tmp/src/snes/interface/snesj.c"
,ierr,PETSC_ERROR_REPEAT," ");} while (0)
;
142 }
143 PetscFunctionReturn(0)do { do { ; if (petscstack && petscstack->currentsize
> 0) { petscstack->currentsize--; petscstack->function
[petscstack->currentsize] = 0; petscstack->file[petscstack
->currentsize] = 0; petscstack->line[petscstack->currentsize
] = 0; petscstack->petscroutine[petscstack->currentsize
] = PETSC_FALSE; } if (petscstack) { petscstack->hotdepth =
(((petscstack->hotdepth-1)<(0)) ? (0) : (petscstack->
hotdepth-1)); } ; } while (0); return(0);} while (0)
;
144}
145
146