Cppcheck report - MOAB: src/mesquite/QualityImprover/OptSolvers/QuasiNewton.hpp

/* *****************************************************************
    MESQUITE -- The Mesh Quality Improvement Toolkit

    Copyright 2007 Sandia National Laboratories.  Developed at the
    University of Wisconsin--Madison under SNL contract number
    624796.  The U.S. Government and the University of Wisconsin
    retain certain rights to this software.

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
    version 2.1 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public License
    (lgpl.txt) along with this library; if not, write to the Free Software
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

    (2008) [email protected]

  ***************************************************************** */

/** \file QuasiNewton.hpp
 *  \brief Port Todd Munson's quasi-Newton solver to Mesquite
 *  \author Jason Kraftcheck
 */

#ifndef MSQ_QUASI_NETWON_HPP
#define MSQ_QUASI_NETWON_HPP

#include "Mesquite.hpp"
#include "VertexMover.hpp"
#include "PatchSetUser.hpp"
#include "MsqHessian.hpp"

namespace MBMesquite
{

class PatchDataVerticesMemento;

class QuasiNewton : public VertexMover, public PatchSetUser
{
  public:
    MESQUITE_EXPORT QuasiNewton( ObjectiveFunction* of );
<--- Class 'QuasiNewton' has a constructor with 1 argument that is not explicit. [+]
Class 'QuasiNewton' has a constructor with 1 argument that is not explicit. Such constructors should in general be explicit for type safety reasons. Using the explicit keyword in the constructor means some mistakes when using the class can be avoided.

    MESQUITE_EXPORT virtual ~QuasiNewton();

    PatchSet* get_patch_set();

    MESQUITE_EXPORT std::string get_name() const;

  protected:
    virtual void initialize( PatchData& pd, MsqError& err );
    virtual void optimize_vertex_positions( PatchData& pd, MsqError& err );
    virtual void initialize_mesh_iteration( PatchData& pd, MsqError& err );
    virtual void terminate_mesh_iteration( PatchData& pd, MsqError& err );
    virtual void cleanup();

    void solve( Vector3D* z, const Vector3D* v ) const;

  private:
    enum Constants
    {
        QNVEC = 5
    };

    PatchDataVerticesMemento* mMemento;
    std::vector< Vector3D > x, v[QNVEC + 1], w[QNVEC + 1], d;
    std::vector< SymMatrix3D > mHess;
};

}  // namespace MBMesquite

#endif