1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145 | /* *****************************************************************
MESQUITE -- The Mesh Quality Improvement Toolkit
Copyright 2006 Sandia National Laboratories. Developed at the
University of Wisconsin--Madison under SNL contract number
624796. The U.S. Government and the University of Wisconsin
retain certain rights to this software.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public License
(lgpl.txt) along with this library; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
(2006) [email protected]
***************************************************************** */
/** \file ElementMaxQM.cpp
* \brief
* \author Jason Kraftcheck
*/
#include "Mesquite.hpp"
#include "ElementMaxQM.hpp"
#include "ElemSampleQM.hpp"
#include "MsqError.hpp"
#include "PatchData.hpp"
#include <limits>
namespace MBMesquite
{
ElementMaxQM::ElementMaxQM( ElemSampleQM* metric ) : mMetric( metric ) {}
ElementMaxQM::~ElementMaxQM() {}
std::string ElementMaxQM::get_name() const
{
std::string result( "ElementMaxQM(" );
result += mMetric->get_name();
result += ")";
return result;
}
int ElementMaxQM::get_negate_flag() const
{
return get_quality_metric()->get_negate_flag();
}
bool ElementMaxQM::evaluate( PatchData& pd, size_t handle, double& value, MsqError& err )
{
ElemSampleQM* qm = get_quality_metric();
mHandles.clear();
qm->get_element_evaluations( pd, handle, mHandles, err );
MSQ_ERRFALSE( err );
bool valid = true;
double tmpval;
bool tmpvalid;<--- The scope of the variable 'tmpvalid' can be reduced. [+]The scope of the variable 'tmpvalid' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
value = -1.e+100; // initialize max computation
for( std::vector< size_t >::iterator h = mHandles.begin(); h != mHandles.end(); ++h )
{
tmpvalid = qm->evaluate( pd, *h, tmpval, err ); // MSQ_ERRZERO(err);
if( !tmpvalid )
{
value = +1.e+100;
return false; // if any handle within the element makes tmpvalid false, then valid is
// false, no matter what the other handles say
}
else if( tmpval > value )
value = tmpval;
}
return valid;
}
/*
bool ElementMaxQM::evaluate_with_gradient( PatchData& pd,
size_t handle,
double& value,
std::vector<size_t>& indices,
std::vector<Vector3D>& gradient,
MsqError& err )
{
ElemSampleQM* qm = get_quality_metric();
mHandles.clear();
qm->get_element_evaluations( pd, handle, mHandles, err ); MSQ_ERRFALSE(err);
bool valid = true;
double tmpval;
bool tmpvalid;
unsigned count = 0;
std::vector<size_t>::iterator h, i, j;
value = -std::numeric_limits<double>::maximum();
for (h = mHandles.begin(); h != mHandles.end(); ++h) {
mIndices.clear();
mGrad.clear();
tmpvalid = qm->evaluate_with_gradient( pd, *h, tmpval, mIndices, mGrad, err );
MSQ_ERRZERO(err);
if (!tmpvalid) {
valid = false;
}
// new value greater than previous max value
else if (tmpval - value > 1e-6) {
indices = mIndices;
gradient = mGrad;
count = 1;
value = tmpval;
}
// new value equal to previous max value
else if (tmpval - value >= -1e-6) {
++count;
for (i = mIndices.begin(); i != mIndices.end(); ++i) {
j = std::find( indices.begin(), indices.end(), *i );
if (j == indices.end()) {
indices.push_back( *i );
gradient.push_back( mGrad[i - mIndices.begin()] );
}
else {
gradient[j - indices.begin()] += mGrad[i - mIndices.begin()];
}
}
}
}
if (count > 1) {
const double inv_count = 1.0 / count;
for (std::vector<Vector3D>::iterator g = gradient.begin(); g != gradient.end(); ++g)
*g *= inv_count;
}
return valid;
}
*/
} // namespace MBMesquite
|