1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192 | /* *****************************************************************
MESQUITE -- The Mesh Quality Improvement Toolkit
Copyright 2004 Sandia Corporation and Argonne National
Laboratory. Under the terms of Contract DE-AC04-94AL85000
with Sandia Corporation, the U.S. Government retains certain
rights in this software.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public License
(lgpl.txt) along with this library; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
[email protected], [email protected], [email protected],
[email protected], [email protected], [email protected]
***************************************************************** */
/*!
\file VertexConditionNumberQualityMetric.cpp
\brief
\author Michael Brewer
\date 2002-06-9
*/
#include "VertexConditionNumberQualityMetric.hpp"
#include "Vector3D.hpp"
#include "ConditionNumberFunctions.hpp"
#include <cmath>
#include <vector>
using std::vector;
using namespace MBMesquite;
VertexConditionNumberQualityMetric::VertexConditionNumberQualityMetric() : AveragingQM( QualityMetric::LINEAR ) {}
std::string VertexConditionNumberQualityMetric::get_name() const
{
return "Vertex Condition Number";
}
int VertexConditionNumberQualityMetric::get_negate_flag() const
{
return 1;
}
bool VertexConditionNumberQualityMetric::evaluate( PatchData& pd, size_t this_vert, double& fval, MsqError& err )
{
// pd.generate_vertex_to_element_data();
bool return_flag;
fval = MSQ_MAX_CAP;
// get the element array
MsqMeshEntity* elems = pd.get_element_array( err );
// get the vertex to element array and the offset array
// const size_t* elem_offset = pd.get_vertex_to_elem_offset(err); MSQ_ERRZERO(err);
// const size_t* v_to_e_array = pd.get_vertex_to_elem_array(err); MSQ_ERRZERO(err);
// find the offset for this vertex
// size_t this_offset = elem_offset[this_vert];
// get the number of elements attached to this vertex (given by the
// first entry in the vertex to element array)
// size_t num_elems = v_to_e_array[this_offset];
// PRINT_INFO("\nIN LOCAL SIZE CPP, num_elements = %i",num_elems);
// if no elements, then return true
size_t num_elems;
const size_t* v_to_e_array = pd.get_vertex_element_adjacencies( this_vert, num_elems, err );
MSQ_ERRZERO( err );
if( num_elems <= 0 )<--- Unsigned less than zero
{
return true;
}
// create an array to store the local metric values before averaging
// Can we remove this dynamic allocatio?
std::vector< double > met_vals( num_elems );
// vector to hold the other verts which form a corner.
vector< size_t > other_vertices;
other_vertices.reserve( 4 );
size_t i = 0;
// only 3 temp_vec will be sent to cond-num calculator, but the
// additional vector3Ds may be needed during the calculations
size_t elem_index;<--- The scope of the variable 'elem_index' can be reduced. [+]The scope of the variable 'elem_index' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
Vector3D temp_vec[6];
const MsqVertex* vertices = pd.get_vertex_array( err );
// loop over the elements attached to this vertex
for( i = 0; i < num_elems; ++i )
{
// get the vertices connected to this vertex for this element
elem_index = v_to_e_array[i];
elems[elem_index].get_connected_vertices( this_vert, other_vertices, err );
MSQ_ERRZERO( err );
// switch over the element type of this element
switch( elems[v_to_e_array[i]].get_element_type() )
{
case TRIANGLE:
temp_vec[0] = vertices[other_vertices[0]] - vertices[this_vert];
temp_vec[2] = vertices[other_vertices[1]] - vertices[this_vert];
// make relative to equilateral
temp_vec[1] = ( ( 2 * temp_vec[2] ) - temp_vec[0] ) * MSQ_SQRT_THREE_INV;
return_flag = condition_number_2d( temp_vec, elem_index, pd, met_vals[i], err );
MSQ_ERRZERO( err );
if( !return_flag ) return return_flag;
break;
case QUADRILATERAL:
temp_vec[0] = vertices[other_vertices[0]] - vertices[this_vert];
temp_vec[1] = vertices[other_vertices[1]] - vertices[this_vert];
return_flag = condition_number_2d( temp_vec, elem_index, pd, met_vals[i], err );
MSQ_ERRZERO( err );
if( !return_flag ) return return_flag;
break;
case TETRAHEDRON:
temp_vec[0] = vertices[other_vertices[0]] - vertices[this_vert];
temp_vec[3] = vertices[other_vertices[1]] - vertices[this_vert];
temp_vec[4] = vertices[other_vertices[2]] - vertices[this_vert];
// transform to equilateral tet
temp_vec[1] = ( ( 2 * temp_vec[3] ) - temp_vec[0] ) / MSQ_SQRT_THREE;
temp_vec[2] = ( ( 3 * temp_vec[4] ) - temp_vec[0] - temp_vec[3] ) / ( MSQ_SQRT_THREE * MSQ_SQRT_TWO );
return_flag = condition_number_3d( temp_vec, pd, met_vals[i], err );
MSQ_ERRZERO( err );
if( !return_flag ) return return_flag;
break;
case HEXAHEDRON:
temp_vec[0] = vertices[other_vertices[0]] - vertices[this_vert];
temp_vec[1] = vertices[other_vertices[1]] - vertices[this_vert];
temp_vec[2] = vertices[other_vertices[2]] - vertices[this_vert];
return_flag = condition_number_3d( temp_vec, pd, met_vals[i], err );
MSQ_ERRZERO( err );
if( !return_flag ) return return_flag;
break;
default:
MSQ_SETERR( err )
( MsqError::UNSUPPORTED_ELEMENT, "Element type (%d) not uspported in VertexConditionNumberQM.\n",
(int)( elems[v_to_e_array[i]].get_element_type() ) );
fval = MSQ_MAX_CAP;
return false;
} // end switch over element type
other_vertices.clear();
} // end loop over elements
fval = average_metrics( arrptr( met_vals ), num_elems, err );
MSQ_ERRZERO( err );
return true;
}
bool VertexConditionNumberQualityMetric::evaluate_with_indices( PatchData& pd,
size_t this_vert,
double& value,
std::vector< size_t >& indices,
MsqError& err )
{
bool rval = evaluate( pd, this_vert, value, err );
MSQ_ERRFALSE( err );
indices.clear();
MsqMeshEntity* elems = pd.get_element_array( err );
size_t num_elems;
const size_t* v_to_e_array = pd.get_vertex_element_adjacencies( this_vert, num_elems, err );
MSQ_ERRZERO( err );
// vector to hold the other verts which form a corner.
vector< size_t > other_vertices;
other_vertices.reserve( 4 );
size_t i = 0;
// loop over the elements attached to this vertex
for( i = 0; i < num_elems; ++i )
{
// get the vertices connected to this vertex for this element
elems[v_to_e_array[i]].get_connected_vertices( this_vert, other_vertices, err );
MSQ_ERRZERO( err );
for( unsigned j = 0; j < other_vertices.size(); ++j )
{
if( other_vertices[j] < pd.num_free_vertices() ) indices.push_back( other_vertices[j] );
}
}
std::sort( indices.begin(), indices.end() );
indices.erase( std::unique( indices.begin(), indices.end() ), indices.end() );
if( this_vert < pd.num_free_vertices() ) indices.push_back( this_vert );
return rval;
}
|