1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199 | ///-----------------------------------------------------------------------------------
// Class: PointLoopFacetor
// Description:
// Creates a set of CubitFacets which is a Delauney triagulation of the boundary
// points. No interior points are added. The points form a closed loop, and may
// consist of several loops. The first loop must be the exterior loop, followed by
// any internal loops (or holes).
// Creator: David R. White
// Owner: David R. White
// Creation Date: 3/1/2003
//------------------------------------------------------------------------------------
#include "PointLoopFacetor.hpp"
#include "DLIList.hpp"
#include "CubitPoint.hpp"
#include "CubitFacet.hpp"
#include "CubitFacetData.hpp"
#include "CubitFacetEdge.hpp"
#include "CubitPointData.hpp"
#include "LoopParamTool.hpp"
#include "TDVector.hpp"
#include "FacetorTool.hpp"
#include <stdio.h>
CubitStatus PointLoopFacetor::generate_facets( PointLoopList &boundary_loops,
DLIList<CubitFacet*> &resulting_triangles)
{
//First transform the boundary points to the XY plane.
LoopParamTool *l_tool = new LoopParamTool;
if ( l_tool->new_space_LoopParam(boundary_loops) != CUBIT_SUCCESS )
{
delete l_tool;
PRINT_ERROR("Faild to generate loop u-v space for generating facets of boundary points.\n");
return CUBIT_FAILURE;
}
//Now transform the poins.
int ii, jj;
if ( l_tool->transform_loopspoints_to_uv(boundary_loops) != CUBIT_SUCCESS )
{
write_xy(boundary_loops);
//Now transform the points back to their original location and remomve the TDVector.
CubitPoint *curr_point;
ToolData *td;<--- The scope of the variable 'td' can be reduced. [+]The scope of the variable 'td' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
TDVector *td_vec;
CubitVector orig_vec;
PointList bounding_points, *curr_list;<--- The scope of the variable 'curr_list' can be reduced. [+]The scope of the variable 'curr_list' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
for ( ii = 0; ii < boundary_loops.size(); ii++)
{
curr_list = boundary_loops.get_and_step();
bounding_points += (*curr_list);
}
for ( ii = 0; ii < bounding_points.size(); ii++ )
{
curr_point = bounding_points.get_and_step();
td = curr_point->get_TD(&TDVector::is_td_vector);
if ( td == NULL )
{
PRINT_ERROR("No TDVector on CubitPoint, can't transform back to x-y-z.\n");
assert(td !=NULL);
}
td_vec = CAST_TO(td, TDVector);
orig_vec = td_vec->get_vector();
curr_point->set(orig_vec);
curr_point->delete_TD(&TDVector::is_td_vector);
}
write_xyz(boundary_loops);
delete l_tool;
PRINT_ERROR("Faild to transform loop to u-v space for generating facets of boundary points.\n");
return CUBIT_FAILURE;
}
delete l_tool;
//now generate a triangulation for these nodes.
int num_boundary_edges = 0;
PointList bounding_points, *curr_list;
for ( ii = 0; ii < boundary_loops.size(); ii++)
{
curr_list = boundary_loops.get_and_step();
num_boundary_edges += curr_list->size();
bounding_points += (*curr_list);
}
CubitPoint **start_nodes = new CubitPoint* [num_boundary_edges];
CubitPoint **end_nodes = new CubitPoint* [num_boundary_edges];
int array_index = 0;
for ( ii = 0; ii < boundary_loops.size(); ii++ )
{
curr_list = boundary_loops.get_and_step();
for ( jj = 0; jj < curr_list->size(); jj++ )
{
assert(array_index < num_boundary_edges);
start_nodes[array_index] = curr_list->get_and_step();
end_nodes[array_index] = curr_list->get();
array_index++;
}
}
if ( array_index != bounding_points.size() )
{
PRINT_ERROR("Problem building edge arrays for faceting.\n");
assert(array_index == bounding_points.size());
return CUBIT_FAILURE;
}
int dummy_variable = -1;
int surf_id = 1;
FacetorTool<int,CubitFacet, CubitFacetEdge,
CubitPoint, CubitFacetData, CubitPointData, int>
facetor = FacetorTool<int,CubitFacet, CubitFacetEdge, CubitPoint,
CubitFacetData, CubitPointData, int> (&surf_id, bounding_points,
start_nodes, end_nodes, num_boundary_edges,
&dummy_variable, l_tool);
if (facetor.mesh_surfwoIP(resulting_triangles) != CUBIT_SUCCESS )
{
PRINT_ERROR("The facetor tool failed.\n");
return CUBIT_FAILURE;
}
//Now transform the points back to their original location and remomve the TDVector.
CubitPoint *curr_point;
ToolData *td;<--- The scope of the variable 'td' can be reduced. [+]The scope of the variable 'td' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
TDVector *td_vec;
CubitVector orig_vec;
for ( ii = 0; ii < bounding_points.size(); ii++ )
{
curr_point = bounding_points.get_and_step();
td = curr_point->get_TD(&TDVector::is_td_vector);
if ( td == NULL )
{
PRINT_ERROR("No TDVector on CubitPoint, can't transform back to x-y-z.\n");
assert(td !=NULL);
}
td_vec = CAST_TO(td, TDVector);
orig_vec = td_vec->get_vector();
curr_point->set(orig_vec);
curr_point->delete_TD(&TDVector::is_td_vector);
}
//Now update the facet planes...
CubitFacet *facet;<--- The scope of the variable 'facet' can be reduced. [+]The scope of the variable 'facet' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
for ( ii = 0; ii < resulting_triangles.size(); ii++ )
{
facet = resulting_triangles.get_and_step();
facet->reset_bounding_box();
facet->update_plane();
}
return CUBIT_SUCCESS;
}
void PointLoopFacetor::write_xyz(PointLoopList &boundary_loops)
{
FILE *fp = fopen("Loop.txt", "w");
if (!fp)
{
PRINT_ERROR("Couldn't open temp file for writing.\n");
return;
}
PointList *node_loop;
CubitPoint *point_ptr;
CubitVector coords;
fprintf(fp, "Real locations\n");
int ii, jj;
for ( ii = boundary_loops.size(); ii > 0; ii-- )
{
node_loop = boundary_loops.get_and_step();
fprintf(fp, "Loop %d, contains %d nodes\n", ii, node_loop->size());
node_loop->reset();
for(jj=0; jj<node_loop->size(); jj++)
{
point_ptr = node_loop->get_and_step();
coords = point_ptr->coordinates();
fprintf(fp,"%d\t%f\t%f\t%f\n", jj, coords.x(), coords.y(), coords.z());
}
}
fclose(fp);
}
void PointLoopFacetor::write_xy(PointLoopList &boundary_loops)
{
FILE *fp = fopen("Loop_transformed.txt", "w");
if (!fp)
{
PRINT_ERROR("Couldn't open temp file for writing.\n");
return;
}
PointList *node_loop;
CubitPoint *point_ptr;
CubitVector coords;
fprintf(fp, "Transformed locations\n");
int ii, jj;
for ( ii = boundary_loops.size(); ii > 0; ii-- )
{
node_loop = boundary_loops.get_and_step();
fprintf(fp, "Loop %d, contains %d nodes\n", ii, node_loop->size());
node_loop->reset();
for(jj=0; jj<node_loop->size(); jj++)
{
point_ptr = node_loop->get_and_step();
coords = point_ptr->coordinates();
fprintf(fp,"%d\t%f\t%f\n", jj, coords.x(), coords.y());
}
}
fclose(fp);
}
|