1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154 | //- Class: CubitPolygon
//- Description: This file defines the CubitPolygon class.
//- Owner: Steve Storm
//- Checked by:
#include <math.h>
#include "CubitPolygon.hpp"
#include "CubitMessage.hpp"
CubitPolygon::CubitPolygon()
{
}
CubitPolygon::CubitPolygon( Cubit2DPoint &start_pnt)
{
add_point( start_pnt );
}
CubitPolygon::CubitPolygon( DLIList<Cubit2DPoint*> &point_list )
{
int i;
point_list.reset();
for ( i = point_list.size(); i--; )
{
Cubit2DPoint *pnt = point_list.get_and_step();
add_point( *pnt );
}
}
CubitPolygon::~CubitPolygon()
{
int i;
for ( i = pointList.size(); i--; )
delete pointList.get_and_step();
}
void
CubitPolygon::add_point( Cubit2DPoint &new_pnt )
{
// Add the point
pointList.append( new Cubit2DPoint( new_pnt ) );
// Update bounding box
if( pointList.size() == 1 )
{
minCoord = new_pnt;
maxCoord = new_pnt;
}
else
new_pnt.update_min_max( minCoord, maxCoord );
}
CubitPointContainment
CubitPolygon::pnt_containment( Cubit2DPoint &pnt,
double tol )
{
// Method is to fire a ray in negative x-direction and check the number
// of intersections with the polygon. Odd - in the loop, Even - outside
// of the loop.
// Returns: CubitPointContainment ( CUBIT_PNT_OUTSIDE = 0,
// CUBIT_PNT_INSIDE = 1,
// CUBIT_PNT_BOUNDARY = 2 )
int i,
c = 0; // Check variable
// First check to see if the point is outside of the bounding box
// of the polygon - if so, return OUT.
if( pnt.x() < minCoord.x()-tol || pnt.y() < minCoord.y()-tol ||
pnt.x() > maxCoord.x()+tol || pnt.y() > maxCoord.y()+tol )
{
return CUBIT_PNT_OUTSIDE;
}
// Loop on line segments of this polygon
Cubit2DPoint *start_pnt, *end_pnt;<--- The scope of the variable 'start_pnt' can be reduced. [+]The scope of the variable 'start_pnt' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level. <--- The scope of the variable 'end_pnt' can be reduced. [+]The scope of the variable 'end_pnt' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
pointList.reset();
for ( i=pointList.size(); i--; )
{
start_pnt = pointList.get_and_step();
end_pnt = pointList.get();
// Check if point lies on the line segment. This is necessary because
// the "fire-ray" code which checks if the point is inside or outside
// the polygon would return outside if the point is on the boundary.
if( pnt.is_on_line_segment( start_pnt, end_pnt, tol ) )
return CUBIT_PNT_BOUNDARY;
// Check if point is in bounds of y of current segment (is it a
// candidate to cross segment?)
if( (start_pnt->y() <= pnt.y() && pnt.y() < end_pnt->y()) ||
(end_pnt->y() <= pnt.y() && pnt.y() < start_pnt->y()) )
{
// It's a candidate
// Check if ray fired in negative x-direction crosses segment
if( pnt.x() < (end_pnt->x()-start_pnt->x()) * (pnt.y()-start_pnt->y()) /
(end_pnt->y()-start_pnt->y()) + start_pnt->x() )
{
// Keeps track of even or odd number of crossings.
// 0-even
// 1-odd
c = !c;
}
}
}
if( c )
// Odd number of crossings
return CUBIT_PNT_INSIDE;
else
// Even number of crossings
return CUBIT_PNT_OUTSIDE;
}
CubitStatus
CubitPolygon::centroid_area( Cubit2DPoint ¢roid, double &area )
{
// Algorithm from Graphics Gems
int n = pointList.size();
if( pointList.size() < 3 )
return CUBIT_FAILURE;
double ai, atmp = 0.0, xtmp = 0.0, ytmp = 0.0;<--- The scope of the variable 'ai' can be reduced. [+]The scope of the variable 'ai' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
Cubit2DPoint *p1, *p2;<--- The scope of the variable 'p2' can be reduced. [+]The scope of the variable 'p2' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
pointList.reset();
for (int j = 0; j < n; j++)
{
p1 = pointList.get_and_step();
p2 = pointList.get();
ai = p1->x() * p2->y() - p2->x() * p1->y();
atmp += ai;
xtmp += ( p2->x() + p1->x() ) * ai;
ytmp += ( p2->y() + p1->y() ) * ai;
}
area = atmp / 2.0;
if (atmp != 0.0)
{
centroid.set( xtmp / (3.0 * atmp), ytmp / (3.0 * atmp) );
return CUBIT_SUCCESS;
}
return CUBIT_FAILURE;
}
|