1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386 | /*
* Usage: MOAB intersection check tool, for intersection on a sphere or in plane
*
* mpiexec -np n ./mbintx_check -s <source mesh> -t <target mesh> -i <intx mesh> -o <source verif>
* -q <target verif>
*
* after a run with mbtempest in parallel, that computes intersection, we can use this tool to
* verify areas of intersection polygons, compared to areas of source, target elements
*
*/
#include <iostream>
#include <cstdlib>
#include <vector>
#include <string>
#include <sstream>
#include <cassert>
#include "moab/Core.hpp"
#include "moab/IntxMesh/IntxUtils.hpp"
#include "moab/ProgOptions.hpp"
#include "moab/CpuTimer.hpp"
#include "DebugOutput.hpp"
#ifdef MOAB_HAVE_MPI
// MPI includes
#include "moab_mpi.h"
#include "moab/ParallelComm.hpp"
#include "MBParallelConventions.h"
#endif
using namespace moab;
int main( int argc, char* argv[] )
{
std::stringstream sstr;<--- Unused variable: sstr
// Default area_method = lHuiller; Options: Girard, GaussQuadrature (if TR is available)
const IntxAreaUtils::AreaMethod areaMethod = IntxAreaUtils::lHuiller;
int rank = 0, size = 1;<--- 'size' is assigned value '1' here.<--- 'rank' is assigned value '0' here.<--- 'rank' is assigned value '0' here.<--- 'rank' is assigned value '0' here.<--- 'rank' is assigned value '0' here.<--- 'rank' is assigned value '0' here.
#ifdef MOAB_HAVE_MPI
MPI_Init( &argc, &argv );
MPI_Comm_rank( MPI_COMM_WORLD, &rank );
MPI_Comm_size( MPI_COMM_WORLD, &size );
#endif
std::string sourceFile, targetFile, intxFile;
std::string source_verif( "outS.h5m" ), target_verif( "outt.h5m" );
int sphere = 1;
int oldNamesParents = 1;
double areaErrSource = -1;
double areaErrTarget = -1;
ProgOptions opts;
opts.addOpt< std::string >( "source,s", "source file ", &sourceFile );
opts.addOpt< std::string >( "target,t", "target file ", &targetFile );
opts.addOpt< std::string >( "intersection,i", "intersection file ", &intxFile );
opts.addOpt< std::string >( "verif_source,v", "output source verification ", &source_verif );
opts.addOpt< std::string >( "verif_target,w", "output target verification ", &target_verif );
opts.addOpt< double >( "threshold_source,m", "error source threshold ", &areaErrSource );
opts.addOpt< double >( "threshold_target,q", "error target threshold ", &areaErrTarget );
opts.addOpt< int >( "sphere,p", "mesh on a sphere", &sphere );
opts.addOpt< int >( "old_convention,n", "old names for parent tags", &oldNamesParents );
opts.parseCommandLine( argc, argv );
// load meshes in parallel if needed
std::string opts_read = ( size == 1 ? ""<--- The comparison 'size == 1' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
: std::string( "PARALLEL=READ_PART;PARTITION=PARALLEL_PARTITION" ) +
std::string( ";PARALLEL_RESOLVE_SHARED_ENTS" ) );
// read meshes in 3 file sets
ErrorCode rval;
Core moab;
Interface* mb = &moab; // global
EntityHandle sset, tset, ixset;
// create meshsets and load files
rval = mb->create_meshset( MESHSET_SET, sset );MB_CHK_ERR( rval );
rval = mb->create_meshset( MESHSET_SET, tset );MB_CHK_ERR( rval );
rval = mb->create_meshset( MESHSET_SET, ixset );MB_CHK_ERR( rval );
if( 0 == rank ) std::cout << "Loading source file " << sourceFile << "\n";<--- The comparison '0 == rank' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
rval = mb->load_file( sourceFile.c_str(), &sset, opts_read.c_str() );MB_CHK_SET_ERR( rval, "failed reading source file" );
if( 0 == rank ) std::cout << "Loading target file " << targetFile << "\n";<--- The comparison '0 == rank' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
rval = mb->load_file( targetFile.c_str(), &tset, opts_read.c_str() );MB_CHK_SET_ERR( rval, "failed reading target file" );
if( 0 == rank ) std::cout << "Loading intersection file " << intxFile << "\n";<--- The comparison '0 == rank' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
rval = mb->load_file( intxFile.c_str(), &ixset, opts_read.c_str() );MB_CHK_SET_ERR( rval, "failed reading intersection file" );
double R = 1.;
if( sphere )
{
// fix radius of both meshes, to be consistent with radius 1
rval = moab::IntxUtils::ScaleToRadius( mb, sset, R );MB_CHK_ERR( rval );
rval = moab::IntxUtils::ScaleToRadius( mb, tset, R );MB_CHK_ERR( rval );
}
Range intxCells;
rval = mb->get_entities_by_dimension( ixset, 2, intxCells );MB_CHK_ERR( rval );
Range sourceCells;
rval = mb->get_entities_by_dimension( sset, 2, sourceCells );MB_CHK_ERR( rval );
Range targetCells;
rval = mb->get_entities_by_dimension( tset, 2, targetCells );MB_CHK_ERR( rval );
Tag sourceParentTag;
Tag targetParentTag;
if( oldNamesParents )
{
rval = mb->tag_get_handle( "RedParent", targetParentTag );MB_CHK_SET_ERR( rval, "can't find target parent tag" );
rval = mb->tag_get_handle( "BlueParent", sourceParentTag );MB_CHK_SET_ERR( rval, "can't find source parent tag" );
}
else
{
rval = mb->tag_get_handle( "TargetParent", targetParentTag );MB_CHK_SET_ERR( rval, "can't find target parent tag" );
rval = mb->tag_get_handle( "SourceParent", sourceParentTag );MB_CHK_SET_ERR( rval, "can't find source parent tag" );
}
// error sets, for better visualization
EntityHandle errorSourceSet;
rval = mb->create_meshset( MESHSET_SET, errorSourceSet );MB_CHK_ERR( rval );
EntityHandle errorTargetSet;
rval = mb->create_meshset( MESHSET_SET, errorTargetSet );MB_CHK_ERR( rval );
std::map< int, double > sourceAreas;
std::map< int, double > targetAreas;
std::map< int, double > sourceAreasIntx;
std::map< int, double > targetAreasIntx;
std::map< int, int > sourceNbIntx;
std::map< int, int > targetNbIntx;
std::map< int, EntityHandle > sourceMap;
std::map< int, EntityHandle > targetMap;
Tag gidTag = mb->globalId_tag();
Tag areaTag;
rval = mb->tag_get_handle( "OrigArea", 1, MB_TYPE_DOUBLE, areaTag, MB_TAG_DENSE | MB_TAG_CREAT );MB_CHK_ERR( rval );
moab::IntxAreaUtils areaAdaptor( areaMethod );
Range non_convex_intx_cells;
for( Range::iterator eit = sourceCells.begin(); eit != sourceCells.end(); ++eit )
{
EntityHandle cell = *eit;
const EntityHandle* verts;
int num_nodes;
rval = mb->get_connectivity( cell, verts, num_nodes );MB_CHK_ERR( rval );
if( MB_SUCCESS != rval ) return -1;
std::vector< double > coords( 3 * num_nodes );
// get coordinates
rval = mb->get_coords( verts, num_nodes, &coords[0] );
if( MB_SUCCESS != rval ) return -1;
double area = areaAdaptor.area_spherical_polygon( &coords[0], num_nodes, R );
int sourceID;
rval = mb->tag_get_data( gidTag, &cell, 1, &sourceID );MB_CHK_ERR( rval );
sourceAreas[sourceID] = area;
rval = mb->tag_set_data( areaTag, &cell, 1, &area );MB_CHK_ERR( rval );
sourceMap[sourceID] = cell;
}
for( Range::iterator eit = targetCells.begin(); eit != targetCells.end(); ++eit )
{
EntityHandle cell = *eit;
const EntityHandle* verts;
int num_nodes;
rval = mb->get_connectivity( cell, verts, num_nodes );MB_CHK_ERR( rval );
if( MB_SUCCESS != rval ) return -1;
std::vector< double > coords( 3 * num_nodes );
// get coordinates
rval = mb->get_coords( verts, num_nodes, &coords[0] );
if( MB_SUCCESS != rval ) return -1;
double area = areaAdaptor.area_spherical_polygon( &coords[0], num_nodes, R );
int targetID;
rval = mb->tag_get_data( gidTag, &cell, 1, &targetID );MB_CHK_ERR( rval );
targetAreas[targetID] = area;
rval = mb->tag_set_data( areaTag, &cell, 1, &area );MB_CHK_ERR( rval );
targetMap[targetID] = cell;
}
for( Range::iterator eit = intxCells.begin(); eit != intxCells.end(); ++eit )
{
EntityHandle cell = *eit;
const EntityHandle* verts;
int num_nodes;
rval = mb->get_connectivity( cell, verts, num_nodes );MB_CHK_ERR( rval );
if( MB_SUCCESS != rval ) return -1;
std::vector< double > coords( 3 * num_nodes );
// get coordinates
rval = mb->get_coords( verts, num_nodes, &coords[0] );
if( MB_SUCCESS != rval ) return -1;
int check_sign = 1;
double intx_area = areaAdaptor.area_spherical_polygon( &coords[0], num_nodes, R, &check_sign );
rval = mb->tag_set_data( areaTag, &cell, 1, &intx_area );
;MB_CHK_ERR( rval );
int sourceID, targetID;
rval = mb->tag_get_data( sourceParentTag, &cell, 1, &sourceID );MB_CHK_ERR( rval );
rval = mb->tag_get_data( targetParentTag, &cell, 1, &targetID );MB_CHK_ERR( rval );
std::map< int, double >::iterator sit = sourceAreasIntx.find( sourceID );
if( sit == sourceAreasIntx.end() )
{
sourceAreasIntx[sourceID] = intx_area;
sourceNbIntx[sourceID] = 1;
}
else
{
sourceAreasIntx[sourceID] += intx_area;
sourceNbIntx[sourceID]++;
}
std::map< int, double >::iterator tit = targetAreasIntx.find( targetID );
if( tit == targetAreasIntx.end() )
{
targetAreasIntx[targetID] = intx_area;
targetNbIntx[targetID] = 1;
}
else
{
targetAreasIntx[targetID] += intx_area;
targetNbIntx[targetID]++;
}
if( intx_area < 0 )
{
std::cout << "negative intx area: " << intx_area << " n:" << num_nodes << " parents: " << sourceID << " "
<< targetID << "\n";
}
if( check_sign < 0 )
{
non_convex_intx_cells.insert( cell );
std::cout << " non-convex polygon: " << intx_area << " n:" << num_nodes << " parents: " << sourceID << " "
<< targetID << "\n";
}
}
Tag diffTag;
rval = mb->tag_get_handle( "AreaDiff", 1, MB_TYPE_DOUBLE, diffTag, MB_TAG_DENSE | MB_TAG_CREAT );MB_CHK_ERR( rval );
Tag countIntxCellsTag;
rval = mb->tag_get_handle( "CountIntx", 1, MB_TYPE_INTEGER, countIntxCellsTag, MB_TAG_DENSE | MB_TAG_CREAT );MB_CHK_ERR( rval );
for( Range::iterator eit = sourceCells.begin(); eit != sourceCells.end(); ++eit )
{
EntityHandle cell = *eit;
int sourceID;
rval = mb->tag_get_data( gidTag, &cell, 1, &sourceID );MB_CHK_ERR( rval );
double areaDiff = sourceAreas[sourceID];
std::map< int, double >::iterator sit = sourceAreasIntx.find( sourceID );
int countIntxCells = 0;
if( sit != sourceAreasIntx.end() )
{
areaDiff -= sourceAreasIntx[sourceID];
countIntxCells = sourceNbIntx[sourceID];
}
rval = mb->tag_set_data( diffTag, &cell, 1, &areaDiff );<--- rval is assigned
rval = mb->tag_set_data( countIntxCellsTag, &cell, 1, &countIntxCells );<--- rval is overwritten<--- rval is assigned
// add to errorSourceSet set if needed
if( ( areaErrSource > 0 ) && ( fabs( areaDiff ) > areaErrSource ) )
{
rval = mb->add_entities( errorSourceSet, &cell, 1 );MB_CHK_ERR( rval );
}
}
if( 0 == rank ) std::cout << "write source verification file " << source_verif << "\n";<--- The comparison '0 == rank' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
rval = mb->write_file( source_verif.c_str(), 0, 0, &sset, 1 );MB_CHK_ERR( rval );<--- rval is overwritten
if( areaErrSource > 0 )
{
Range sourceErrorCells;
rval = mb->get_entities_by_handle( errorSourceSet, sourceErrorCells );MB_CHK_ERR( rval );
EntityHandle errorSourceIntxSet;
rval = mb->create_meshset( MESHSET_SET, errorSourceIntxSet );MB_CHK_ERR( rval );
if( !sourceErrorCells.empty() )
{
// add the intx cells that have these as source parent
std::vector< int > sourceIDs;
sourceIDs.resize( sourceErrorCells.size() );
rval = mb->tag_get_data( gidTag, sourceErrorCells, &sourceIDs[0] );MB_CHK_SET_ERR( rval, "can't get source IDs" );
std::sort( sourceIDs.begin(), sourceIDs.end() );
for( Range::iterator eit = intxCells.begin(); eit != intxCells.end(); ++eit )
{
EntityHandle cell = *eit;
int sourceID;
rval = mb->tag_get_data( sourceParentTag, &cell, 1, &sourceID );MB_CHK_ERR( rval );
std::vector< int >::iterator j = std::lower_bound( sourceIDs.begin(), sourceIDs.end(), sourceID );
if( ( j != sourceIDs.end() ) && ( *j == sourceID ) )
{
rval = mb->add_entities( errorSourceIntxSet, &cell, 1 );
;MB_CHK_ERR( rval );
}
}
std::string filtersource = std::string( "filt_" ) + source_verif;
rval = mb->write_file( filtersource.c_str(), 0, 0, &errorSourceSet, 1 );<--- rval is assigned
std::string filterIntxsource = std::string( "filtIntx_" ) + source_verif;
rval = mb->write_file( filterIntxsource.c_str(), 0, 0, &errorSourceIntxSet, 1 );<--- rval is overwritten<--- rval is assigned
}
}
for( Range::iterator eit = targetCells.begin(); eit != targetCells.end(); ++eit )
{
EntityHandle cell = *eit;
int targetID;
rval = mb->tag_get_data( gidTag, &cell, 1, &targetID );MB_CHK_ERR( rval );
double areaDiff = targetAreas[targetID];
int countIntxCells = 0;
std::map< int, double >::iterator sit = targetAreasIntx.find( targetID );
if( sit != targetAreasIntx.end() )
{
areaDiff -= targetAreasIntx[targetID];
countIntxCells = targetNbIntx[targetID];
}
rval = mb->tag_set_data( diffTag, &cell, 1, &areaDiff );<--- rval is assigned
rval = mb->tag_set_data( countIntxCellsTag, &cell, 1, &countIntxCells );<--- rval is overwritten<--- rval is assigned
// add to errorTargetSet set if needed
if( ( areaErrTarget > 0 ) && ( fabs( areaDiff ) > areaErrTarget ) )
{
rval = mb->add_entities( errorTargetSet, &cell, 1 );MB_CHK_ERR( rval );
}
}
if( 0 == rank ) std::cout << "write target verification file " << target_verif << "\n";<--- The comparison '0 == rank' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
rval = mb->write_file( target_verif.c_str(), 0, 0, &tset, 1 );MB_CHK_ERR( rval );<--- rval is overwritten<--- rval is overwritten
if( areaErrTarget > 0 )
{
Range targetErrorCells;
rval = mb->get_entities_by_handle( errorTargetSet, targetErrorCells );MB_CHK_ERR( rval );
if( !targetErrorCells.empty() )
{
EntityHandle errorTargetIntxSet;
rval = mb->create_meshset( MESHSET_SET, errorTargetIntxSet );MB_CHK_ERR( rval );
// add the intx cells that have these as target parent
std::vector< int > targetIDs;
targetIDs.resize( targetErrorCells.size() );
rval = mb->tag_get_data( gidTag, targetErrorCells, &targetIDs[0] );MB_CHK_SET_ERR( rval, "can't get target IDs" );
std::sort( targetIDs.begin(), targetIDs.end() );
for( Range::iterator eit = intxCells.begin(); eit != intxCells.end(); ++eit )
{
EntityHandle cell = *eit;
int targetID;
rval = mb->tag_get_data( targetParentTag, &cell, 1, &targetID );MB_CHK_ERR( rval );
std::vector< int >::iterator j = std::lower_bound( targetIDs.begin(), targetIDs.end(), targetID );
if( ( j != targetIDs.end() ) && ( *j == targetID ) )
{
rval = mb->add_entities( errorTargetIntxSet, &cell, 1 );
;MB_CHK_ERR( rval );
}
}
std::string filterTarget = std::string( "filt_" ) + target_verif;
rval = mb->write_file( filterTarget.c_str(), 0, 0, &errorTargetSet, 1 );<--- rval is assigned
std::string filterIntxtarget = std::string( "filtIntx_" ) + target_verif;
rval = mb->write_file( filterIntxtarget.c_str(), 0, 0, &errorTargetIntxSet, 1 );<--- rval is overwritten
}
}
if( !non_convex_intx_cells.empty() )
{
sourceCells.clear();
targetCells.clear();
for( Range::iterator it = non_convex_intx_cells.begin(); it != non_convex_intx_cells.end(); it++ )<--- Prefer prefix ++/-- operators for non-primitive types. [+]Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
{
EntityHandle cellIntx = *it;
int sourceID, targetID;
rval = mb->tag_get_data( sourceParentTag, &cellIntx, 1, &sourceID );MB_CHK_ERR( rval );
rval = mb->tag_get_data( targetParentTag, &cellIntx, 1, &targetID );MB_CHK_ERR( rval );
sourceCells.insert( sourceMap[sourceID] );
targetCells.insert( targetMap[targetID] );
}
EntityHandle nonConvexSet;
rval = mb->create_meshset( MESHSET_SET, nonConvexSet );MB_CHK_ERR( rval );
rval = mb->add_entities( nonConvexSet, non_convex_intx_cells );<--- rval is assigned
rval = mb->write_file( "nonConvex.h5m", 0, 0, &nonConvexSet, 1 );MB_CHK_ERR( rval );<--- rval is overwritten
EntityHandle sSet;
rval = mb->create_meshset( MESHSET_SET, sSet );MB_CHK_ERR( rval );
rval = mb->add_entities( sSet, sourceCells );<--- rval is assigned
rval = mb->write_file( "nonConvexSource.h5m", 0, 0, &sSet, 1 );MB_CHK_ERR( rval );<--- rval is overwritten
EntityHandle tSet;
rval = mb->create_meshset( MESHSET_SET, tSet );MB_CHK_ERR( rval );
rval = mb->add_entities( tSet, targetCells );<--- rval is assigned
rval = mb->write_file( "nonConvexTarget.h5m", 0, 0, &tSet, 1 );MB_CHK_ERR( rval );<--- rval is overwritten
rval = mb->add_entities( nonConvexSet, sourceCells );<--- rval is assigned
rval = mb->add_entities( nonConvexSet, targetCells );<--- rval is overwritten<--- rval is assigned
rval = mb->write_file( "nonConvexAll.h5m", 0, 0, &nonConvexSet, 1 );MB_CHK_ERR( rval );<--- rval is overwritten
}
return 0;
}
|