1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281 | #include <iostream>
#include <cstdlib>
#include <vector>
#include <map>
#include <string>
#include <cstdio>
#include <iomanip>
#include <fstream>
#include "moab/MOABConfig.h"
#ifdef MOAB_HAVE_MPI
#include "moab_mpi.h"
#include "moab/ParallelComm.hpp"
#endif
#if !defined( _MSC_VER ) && !defined( __MINGW32__ )
#include <termios.h>
#include <sys/ioctl.h>
#endif
#include <cmath>
#include <cassert>
#include <cfloat>
#include "moab/Core.hpp"
#include "moab/Range.hpp"
#include "MBTagConventions.hpp"
#include "moab/Interface.hpp"
#include "moab/verdict/VerdictWrapper.hpp"
using namespace moab;
static void print_usage( const char* name, std::ostream& stream )
{
stream << "Usage: " << name << " <input_file> [<output_file>]" << std::endl;
}
int main( int argc, char* argv[] )
{
int proc_id = 0, size = 1;<--- 'proc_id' is assigned value '0' here.<--- 'size' is assigned value '1' here.<--- 'size' is assigned value '1' here.<--- 'proc_id' is assigned value '0' here.<--- 'proc_id' is assigned value '0' here.
#ifdef MOAB_HAVE_MPI
MPI_Init( &argc, &argv );
MPI_Comm_rank( MPI_COMM_WORLD, &proc_id );
MPI_Comm_size( MPI_COMM_WORLD, &size );
#endif
if( argc < 2 && 0 == proc_id )<--- The comparison '0 == proc_id' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
{
print_usage( argv[0], std::cerr );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
Core mb;
std::string read_options;
if( size > 1 ) read_options = "PARALLEL=READ_PART;PARTITION=PARALLEL_PARTITION;PARALLEL_RESOLVE_SHARED_ENTS";<--- The comparison 'size > 1' is always false. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
if( size > 1 && argc > 2 )<--- The comparison 'size > 1' is always false. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
{
std::cerr << " cannot use verbose option in parallel \n";
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
char* out_file = NULL;
std::ofstream ofile;
if( argc == 3 )
{
std::cout << " write verbose output to a CSV file " << argv[2] << "\n";
out_file = argv[2];
ofile.open( out_file );
}
if( MB_SUCCESS != mb.load_file( argv[1], 0, read_options.c_str() ) )
{
fprintf( stderr, "Error reading file: %s\n", argv[1] );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
VerdictWrapper vw( &mb );
vw.set_size( 1. ); // for relative size measures; maybe it should be user input
Range entities;
ErrorCode rval = mb.get_entities_by_handle( 0, entities );
if( MB_SUCCESS != rval )
{
fprintf( stderr, "Error getting entities from file %s\n", argv[1] );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
// get all edges and faces, force them to be created
Range allfaces, alledges;
Range cells = entities.subset_by_dimension( 3 );
rval = mb.get_adjacencies( cells, 2, true, allfaces, Interface::UNION );
if( MB_SUCCESS != rval )
{
fprintf( stderr, "Error getting all faces" );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
rval = mb.get_adjacencies( allfaces, 1, true, alledges, Interface::UNION );
if( MB_SUCCESS != rval )
{
fprintf( stderr, "Error getting all edges" );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
entities.merge( allfaces );
entities.merge( alledges );
for( EntityType et = MBENTITYSET; et >= MBEDGE; et-- )
{
int num_qualities = vw.num_qualities( et );
if( !num_qualities ) continue;
Range owned = entities.subset_by_type( et );
std::map< QualityType, double > qualities, minq, maxq;
int ne_local = (int)owned.size();
int ne_global = ne_local;<--- 'ne_global' is assigned value 'ne_local' here.
#ifdef MOAB_HAVE_MPI
int mpi_err;
if( size > 1 )
{
// filter the entities not owned, so we do not process them more than once
ParallelComm* pcomm = ParallelComm::get_pcomm( &mb, 0 );
Range current = owned;
owned.clear();
rval = pcomm->filter_pstatus( current, PSTATUS_NOT_OWNED, PSTATUS_NOT, -1, &owned );
if( rval != MB_SUCCESS )
{
MPI_Finalize();
return 1;
}
ne_local = (int)owned.size();
mpi_err = MPI_Reduce( &ne_local, &ne_global, 1, MPI_INT, MPI_SUM, 0, MPI_COMM_WORLD );
if( mpi_err )
{
MPI_Finalize();
return 1;
}
}
#endif
if( ne_global > 0 )<--- outer condition: ne_global>0
{
if( ne_local > 0 )<--- identical inner condition: ne_local>0
{
Range::iterator it = owned.begin();
rval = vw.all_quality_measures( *it, qualities );
if( MB_SUCCESS != rval )
{
fprintf( stderr, "Error getting quality for entity type %d with id %ld \n", et,
(long)mb.id_from_handle( *it ) );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
if( ofile.is_open() )
{
// write first header or this entity type, then the first values, separated by
// commas
ofile << " There are " << ne_local << " entities of type " << vw.entity_type_name( et ) << " with "
<< qualities.size() << " qualities:\n"
<< " Entity id ";
for( std::map< QualityType, double >::iterator qit = qualities.begin(); qit != qualities.end();
++qit )
{
ofile << ", " << vw.quality_name( qit->first );
}
ofile << "\n";
ofile << mb.id_from_handle( *it );
for( std::map< QualityType, double >::iterator qit = qualities.begin(); qit != qualities.end();
++qit )
{
ofile << ", " << qit->second;
}
ofile << "\n";
}
minq = qualities;
maxq = qualities;
++it;
for( ; it != owned.end(); ++it )
{
rval = vw.all_quality_measures( *it, qualities );
if( MB_SUCCESS != rval )
{
fprintf( stderr, "Error getting quality for entity type %d with id %ld \n", et,
(long)mb.id_from_handle( *it ) );
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 1;
}
if( ofile.is_open() )
{
ofile << mb.id_from_handle( *it );
for( std::map< QualityType, double >::iterator qit = qualities.begin(); qit != qualities.end();
++qit )
{
ofile << ", " << qit->second;
}
ofile << "\n";
}
std::map< QualityType, double >::iterator minit = minq.begin();
std::map< QualityType, double >::iterator maxit = maxq.begin();
for( std::map< QualityType, double >::iterator mit = qualities.begin(); mit != qualities.end();
++mit, ++minit, ++maxit )
{
if( mit->second > maxit->second ) maxit->second = mit->second;
if( mit->second < minit->second ) minit->second = mit->second;
}
}
}
if( 0 == proc_id )<--- The comparison '0 == proc_id' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
{
std::cout << " \n\n " << ne_global << " entities of type " << vw.entity_type_name( et ) << "\n";
std::cout << std::setw( 30 ) << "Quality Name" << std::setw( 15 ) << " MIN" << std::setw( 15 )
<< " MAX"
<< "\n";
}
QualityType quality_type = MB_EDGE_RATIO;
for( int i = 0; i < num_qualities; i++, quality_type = (QualityType)( quality_type + 1 ) )
{
while( !( vw.possible_quality( et, quality_type ) ) && quality_type < MB_QUALITY_COUNT )
quality_type = (QualityType)( quality_type + 1 ); // will get them in order
const char* name_q = vw.quality_name( quality_type );
double local_min, global_min;
double local_max, global_max;
if( ne_local > 0 )
{
local_min = minq[quality_type];
local_max = maxq[quality_type];
}
else
{
local_min = 1.e38; // so this task has no entities of this type
local_max = -1.e38; // it can get here only in parallel
}
#ifdef MOAB_HAVE_MPI
mpi_err = MPI_Reduce( &local_min, &global_min, 1, MPI_DOUBLE, MPI_MIN, 0, MPI_COMM_WORLD );
if( mpi_err )
{
MPI_Finalize();
return 1;
}
mpi_err = MPI_Reduce( &local_max, &global_max, 1, MPI_DOUBLE, MPI_MAX, 0, MPI_COMM_WORLD );
if( mpi_err )
{
MPI_Finalize();
return 1;
}
#else
global_min = local_min;
global_max = local_max;
#endif
if( 0 == proc_id )<--- The comparison '0 == proc_id' is always true. [+]Finding the same expression on both sides of an operator is suspicious and might indicate a cut and paste or logic error. Please examine this code carefully to determine if it is correct.
{
std::cout << std::setw( 30 ) << name_q << std::setw( 15 ) << global_min << std::setw( 15 )
<< global_max << "\n";
}
}
}
} // etype
if( ofile.is_open() )
{
ofile.close();
}
#ifdef MOAB_HAVE_MPI
MPI_Finalize();
#endif
return 0;
}
|